[java][jaxrs-spec][quarkus] - PArt 3 - userecords#24188
Draft
Ignacio-Vidal wants to merge 1 commit into
Draft
Conversation
db470ed to
98fdba1
Compare
Adds a useRecords option to the jaxrs-spec generator. When useRecords=true, the concrete subtypes that implement a generated oneOf interface render as Java records instead of mutable classes. - JavaJAXRSSpecServerCodegen: useRecords option, and postProcessAllModels marks record-eligible implementors with x-jaxrs-record (no parent, no additional properties, implements a generated oneOf interface). - record.mustache renders the record; model.mustache routes x-jaxrs-record to it. - oneof_interface.mustache declares the discriminator accessor in record style (petType()) under useRecords so records satisfy the interface via their canonical accessors; sealed.mustache no longer marks a record final. - pom.mustache bumps java.version to 17 when useRecords (records need JDK 16+). - Adds testOneOfRecordImplementationGeneration and a jaxrs-spec-records sample (registered in the JDK17 samples workflow). useRecords is independent of useSealed. The feature stays opt-in; default jaxrs-spec output is unchanged.
98fdba1 to
940a93b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Adds
useOneOfInterfaces,useSealed, anduseRecordstojaxrs-specto generate oneOf interfaces, optional sealed hierarchies, and record implementations; updates discriminator mapping and accessor signatures so polymorphic serialization works and record outputs compile cleanly.New Features
useOneOfInterfaces: oneOf schemas render as Java interfaces; subtypes implement them; interface carries typed discriminator getter and Jackson type annotations viaoneof_interfacetemplate.useSealed: marks the interface sealed and lists permitted subtypes; implementing classes become final; POM switches to Java 17.useRecords: eligible implementors of a generated oneOf interface render as Java records (no parent, no additionalProperties); the interface declares the discriminator accessor in record style so records satisfy it; records are not forced final; POM switches to Java 17. Independent ofuseSealed.model.mustache, sealed/permits helpers,record.mustache); new sample/config (jaxrs-spec-records) added and included in the JDK17 samples workflow.Bug Fixes
@JsonTypeNamefor subtypes from the oneOf interface’s mapped children when the parent is an interface, avoiding String fallback and ensuring correct enum types.Written for commit 940a93b. Summary will update on new commits.